add test for spherical_coslat_differential #123
Conversation
…ns, update io.hpp to print differential systems
rjnrohit
changed the title
| DimensionCount, | ||
| CoordinateSystem | ||
| > | ||
| get_point() const |
There was a problem hiding this comment.
Function to return current differential of this object. By doing this we are able to calculate cross of differential objects.
| auto cross | ||
| ( | ||
| cartesian_differential<Args1...> const& representation1, | ||
| Representation2<Args2...> const& representation2 |
There was a problem hiding this comment.
As you have made this function to support differentials, you should name the arguments differential1 and differential2 instead of representation1 and representation2 to maintain uniformity in the library. And change this whole function accordingly.
| DimensionCount, | ||
| CoordinateSystem | ||
| > | ||
| get_point() const |
There was a problem hiding this comment.
What is the need of this function? get_differential is already there in base_differential.hpp.
There was a problem hiding this comment.
By doing this we can extend all arithmetic function to work for differentials as well. Otherwise, we may get a conflict of .get_point() in all arithmetic functions.
There was a problem hiding this comment.
I guess this will help in magnitude function. But functions like sum, mean, difference, dot use make_cartesian_representation() and hence can't be extended to work for differentials by defining get_point for differential.
There was a problem hiding this comment.
It'll also help to calculate cross for two differential classes or one representation class and one differential class. In the code where we used
bg::transform(cartesian1.get_point(), tempPoint1); bg::transform(cartesian2.get_point(), tempPoint2);
There was a problem hiding this comment.
@sarthak2007 I'm closing this PR. I have created a separate PR #127 for the extension of arithmetic functions to support differential systems.
Ok. I'll create a new PR for every context. |
rjnrohit
changed the title
Description
6.Now, cross can also calculate cross product of differential motion objects too.
References
Tasklist